Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: test with sqlalchemy 2.0 #96893

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Feb 9, 2023

fixes #96880
backports for #96859 and #96856

Release note: None

@rafiss rafiss requested review from ZhouXing19 and a team February 9, 2023 18:41
@rafiss rafiss requested a review from a team as a code owner February 9, 2023 18:41
@rafiss rafiss requested review from herkolategan and srosenberg and removed request for a team February 9, 2023 18:41
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@ZhouXing19 ZhouXing19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rafiss
Copy link
Collaborator Author

rafiss commented Feb 9, 2023

tftr!

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 9, 2023

Build succeeded:

@craig craig bot merged commit faeebee into cockroachdb:master Feb 9, 2023
@rafiss rafiss deleted the fix-sqlalchemy branch February 9, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: sqlalchemy failed
3 participants